Henry Robinson commented on ZOOKEEPER-769:

Sergey - 

Great, thanks for making this patch! ISTR there was some reason why we didn't 
infer peerType from the servers list, but I can't remember what it was...

As for your patch, a few small comments:

1. Use --no-prefix and just attach the output of git-diff (no mail headers etc) 
- Hudson is rather picky about the patch formats it can apply
2. It would be great to include a test that reads a configuration and checks 
that the behaviour is correct
3. If the peerTypes don't match up, should we default to the server list (on 
the assumption that that will be consistent across all servers)?
4. Once you've added the patch, click 'submit patch' to start Hudson moving.


> Leader can treat observers as quorum members
> --------------------------------------------
>                 Key: ZOOKEEPER-769
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>         Environment: Ubuntu Karmic x64
>            Reporter: Sergey Doroshenko
>            Assignee: Sergey Doroshenko
>             Fix For: 3.4.0
>         Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to