[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868297#action_12868297
 ] 

Maxim P. Dementiev commented on ZOOKEEPER-636:
----------------------------------------------

Sorry for delay. Our project is in trouble 
(http://mpd-eng.livejournal.com/1159.html).

I've changed src/c/Makefile.am: CXXFLAGS should not be overridden.
Anyway, I kept some additional options there ("AM_CFLAGS = -Wall -Werror" and 
"AM_CXXFLAGS = -Wall"). I think it must be moved in configure.ac as well.

It is possible to parse the contents of CFLAGS and CXXFLAGS variable and to add 
specific options conditionally (like it is done for example in 
http://git.gnome.org/browse/gtk+/tree/configure.in?h=gtk-2-18#n320), but we 
need to define requirements for the platform and tool versions (can we use such 
a technique or not).

> configure.ac has instructions which override the contents of CFLAGS and 
> CXXFLAGS.
> ---------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-636
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: build, c client
>    Affects Versions: 3.2.1
>            Reporter: Maxim P. Dementiev
>            Assignee: Maxim P. Dementiev
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-636.patch
>
>
> The information mustn't be overridden.
> The template like «CFLAGS="$CFLAGS -some-option"» should be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to