Patrick Hunt commented on ZOOKEEPER-773:

naming "zkgraph" is not very descriptive - ppl may think it graphs zk 
namespace? How about "logvisualizer" or "loggrapher" (something indicating that 
the contrib visualizes the log). Although even this is potentially misleading 
(txn log vs log4j log). You have a great description at the top of the readme 
which is good though. (perhaps indicate that this is log4j log and not txn log?)

lib dir missing from patch (build fails, I created by hand and it was fine, 
good to get into patch though)

bin scripts are not executable - perhaps update patch, also committer should 
chmod the scripts to add "x" if missing

add apache license to zkgraph.css

LogFormatter.java has license twice

For some reason the app itself does not work for me. I click on the links (I 
tried both chrome and firefox) but nothing happens. "add log" for example, I 
click that and nothing at all happens. Here's the console that's running the 
zkgraph.sh script (this is the entire content of the console):

$ bin/zkgraph.sh 
MergedLogSource(size=0, start=0, end=0)
2010-06-01 09:52:35.695:INFO::Logging to StdErrLog::DEBUG=false via 
2010-06-01 09:52:35.733:INFO::jetty-7.0.1.v20091125
2010-06-01 09:52:35.969:INFO::Started selectchannelconnec...@
log4j:WARN No appenders could be found for logger 
log4j:WARN Please initialize the log4j system properly.

> Log visualisation
> -----------------
>                 Key: ZOOKEEPER-773
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-773
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Minor
>             Fix For: 3.4.0
>         Attachments: ZOOKEEPER-773.diff
> Zkgraph is a log viewer for zookeeper. It can handle transaction logs and 
> message logs. There are currently two view.
>   a) Server view
>      The server view shows the interactions between the different servers in 
> an ensemble. The X axis represents time. 
>         * Exceptions show up as red dots. Hovering your mouse over them will 
> give you more details of the exception
>       * The colour of the line represents the election state of the server. 
>          - orange means LOOKING for leader
>          - dark green means the server is the leader
>          - light green means the server is following a leader
>          - yellow means there isn't enough information to determine the state 
> of the server. 
>       * The gray arrows denote election messages between servers. Pink dashed 
> arrows are messages that were sent but never delivered.
>    b) Session view
>       The session view shows the lifetime of sessions on a server. Use the 
> time filter to narrow down the view. Any more than about 2000 events will 
> take a long time to view in your browser. 
>       The Y axis represents time in this case. Each line is a session. The 
> black dots represent events on the session. You can click on the black dots 
> for more details of the event.
> 2 - Compiling & Running
> Run "ant jar" in src/contrib/zkgraph/. This will download all dependencies 
> and compile all the zkgraph code.
> Once compilation has finished, you can run it the the zkgraph.sh script in 
> src/contrib/zkgraph/bin. This will start and embedded web server on you 
> machine. Navigate to http://localhost:8182/graph/main.html.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to