Hadoop QA commented on ZOOKEEPER-796:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 960686.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> zkServer.sh should support an external PIDFILE variable
> -------------------------------------------------------
>                 Key: ZOOKEEPER-796
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-796
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Alex Newman
>            Assignee: Alex Newman
>             Fix For: 3.4.0
>         Attachments: ZOOKEEPER-796.patch, ZOOKEEPER-796.patch
> So currently the pid file has to be tied to the datadirectory when starting 
> zkServer.sh. It would be good to be able to break them up.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to