[
https://issues.apache.org/jira/browse/ZOOKEEPER-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886781#action_12886781
]
Hadoop QA commented on ZOOKEEPER-765:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12449092/ZOOKEEPER-765.patch
against trunk revision 961026.
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 19 release audit warnings
(more than the trunk's current 17 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/138/testReport/
Release audit warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/138/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/138/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/138/console
This message is automatically generated.
> Add python example script
> -------------------------
>
> Key: ZOOKEEPER-765
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-765
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bindings, documentation
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zk.py, ZOOKEEPER-765.patch
>
>
> When adding some zookeeper-based functionality to a python script I had to
> figure everything out without guidance, which while doable, would have been a
> lot easier with an example. I extracted a skeleton program structure out with
> hopes its useful to others (maybe add as an example in the source or wiki?).
> This script does an aget() and sets a watch, and hopefully illustrates what's
> going on, and where to plug in your application code that gets run when the
> znode changes.
> There are probably some bugs, which if we fix now and provide a well-reviewed
> example hopefully others will not run into the same mistakes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
