Hadoop QA commented on ZOOKEEPER-783:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 962697.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> committedLog in ZKDatabase is not properly synchronized
> -------------------------------------------------------
>                 Key: ZOOKEEPER-783
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-783
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.1
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Critical
>             Fix For: 3.3.2, 3.4.0
>         Attachments: ZOOKEEPER-783.patch
> ZKDatabase.getCommittedLog() returns a reference to the LinkedList<Proposal> 
> committedLog in ZKDatabase. This is then iterated over by at least one 
> caller. 
> I have seen a bug that causes a NPE in LinkedList.clear on committedLog, 
> which I am pretty sure is due to the lack of synchronization. This bug has 
> not been apparent in normal ZK operation, but in code that I have that starts 
> and stops a ZK server in process repeatedly (clear() is called from 
> ZooKeeperServerMain.shutdown()). 
> It's better style to defensively copy the list in getCommittedLog, and to 
> synchronize on the list in ZKDatabase.clear.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to