[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892493#action_12892493
 ] 

Mahadev konar commented on ZOOKEEPER-814:
-----------------------------------------

+1 the patch looks good. 

Andrei,
  I think the monitoring tools and scripts are quite useful, though it would 
have been great to have forrest docs for all the plugins like ganglia/others, 
so that we can publish them as part of the release documentation!!  Please 
consider adding forrest documentation (it should not be hard at all)!!! It 
would be really good to have admin documentation link to these forrest docs in 
case they want to use it!

Having all the documentation as forrest docs and availalbe on the documentation 
website (as part of release) will highly increase the adoption of such a plugin!



> monitoring scripts are missing apache license headers
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-814
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: contrib
>            Reporter: Patrick Hunt
>            Assignee: Andrei Savu
>            Priority: Blocker
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-814.patch
>
>
> Andrei, I just realized that src/contrib/monitoring files are missing apache 
> license headers.  Please add them (in particular any script files like 
> python, see similar files in svn for examples - in some cases like README 
> it's not strictly necessary.) 
> You can run the RAT tool to verify (see build.xml or 
> http://incubator.apache.org/rat/)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to