[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893272#action_12893272
 ] 

Patrick Hunt commented on ZOOKEEPER-733:
----------------------------------------

I'm surprised there was no change.

Keep in mind that the default is to continue to use NIO, so if you want to test 
with Netty you need
to set the correct factory:

+        <para>Prior to version 3.4 ZooKeeper has always used NIO
+            directly, however in versions 3.4 and later Netty is
+            supported as an option to NIO (replaces). NIO continues to
+            be the default, however Netty based communication can be
+            used in place of NIO by setting the environment variable
+            "zookeeper.serverCnxnFactory" to
+            "org.apache.zookeeper.server.NettyServerCnxnFactory". 

Regardless - verify which is being used by checking the logs.

One potential problem with netty is that we don't bound the worker thread pool 
size - it would be interesting to see how this
effects the test. There are probably a few of these variables which we should 
provide configuration parameters for...


> use netty to handle client connections
> --------------------------------------
>
>                 Key: ZOOKEEPER-733
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Benjamin Reed
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>
>         Attachments: accessive.jar, flowctl.zip, moved.zip, 
> QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, 
> ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, 
> ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, 
> ZOOKEEPER-733.patch
>
>
> we currently have our own asynchronous NIO socket engine to be able to handle 
> lots of clients with a single thread. over time the engine has become more 
> complicated. we would also like the engine to use multiple threads on 
> machines with lots of cores. plus, we would like to be able to support things 
> like SSL. if we switch to netty, we can simplify our code and get the 
> previously mentioned benefits.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to