[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907144#action_12907144
 ] 

Ivan Kelly commented on ZOOKEEPER-831:
--------------------------------------

asyncAddEntry - why did you move the semaphore acquire in this? If an exception 
occurs during the adding of the operation, is the completion (and therefore the 
release) guaranteed?

Otherwise the patch looks good.

> BookKeeper: Throttling improved for reads
> -----------------------------------------
>
>                 Key: ZOOKEEPER-831
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-831
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>    Affects Versions: 3.3.1
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-831.patch, ZOOKEEPER-831.patch
>
>
> Reads and writes in BookKeeper are asymmetric: a write request writes one 
> entry, whereas a read request may read multiple requests. The current 
> implementation of throttling only counts the number of read requests instead 
> of counting the number of entries being read. Consequently, a few read 
> requests reading a large number of entries each will spawn a large number of 
> read-entry requests. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to