[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907785#action_12907785
 ] 

Erwin Tam commented on ZOOKEEPER-864:
-------------------------------------

Ivan, the changes look good to me.  One question though, do we need to include 
the auto-generated protocol.h header to the Makefile.am?  I had to do that step 
manually a couple of weeks ago otherwise things didn't work when using the 
hedwig client libs generated.

> Hedwig C++ client improvements
> ------------------------------
>
>                 Key: ZOOKEEPER-864
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864
>             Project: Zookeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: warnings.txt, ZOOKEEPER-864.diff, ZOOKEEPER-864.diff, 
> ZOOKEEPER-864.diff
>
>
> I changed the socket code to use boost asio. Now the client only creates one 
> thread, and all operations are non-blocking. 
> Tests are now automated, just run "make check".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to