Patrick Hunt commented on ZOOKEEPER-870:

this looks good, however can you make conditional, where the detail is logged 
at ERROR level if the original assert failed, and at info level otw? you can 
use LOG.log(priority, msg... ) where priority is a conditional value. then we 
can more easily identify errors

also, I'd suggest opening another jira for this same release to revert this 
change at some point. (so we don't forget)

> Zookeeper trunk build broken.
> -----------------------------
>                 Key: ZOOKEEPER-870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-870
>             Project: Zookeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.4.0
>         Attachments: ZOOKEEPER-870.patch
> the zookeeper current trunk build is broken mostly due to some netty changes. 
> This is causing a huge backlog of PA's and other impediments to the review 
> process. For now I plan to disable the test and fix them as part of 3.4 later.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to