[ https://issues.apache.org/jira/browse/ZOOKEEPER-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909635#action_12909635 ]
Hadoop QA commented on ZOOKEEPER-844: ------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12453719/ZOOKEEPER332-844 against trunk revision 997192. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/112/console This message is automatically generated. > handle auth failure in java client > ---------------------------------- > > Key: ZOOKEEPER-844 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-844 > Project: Zookeeper > Issue Type: Bug > Components: java client > Affects Versions: 3.3.1 > Reporter: Camille Fournier > Assignee: Camille Fournier > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-844.patch, ZOOKEEPER332-844 > > > ClientCnxn.java currently has the following code: > if (replyHdr.getXid() == -4) { > // -2 is the xid for AuthPacket > // TODO: process AuthPacket here > if (LOG.isDebugEnabled()) { > LOG.debug("Got auth sessionid:0x" > + Long.toHexString(sessionId)); > } > return; > } > Auth failures appear to cause the server to disconnect but the client never > gets a proper state change or notification that auth has failed, which makes > handling this scenario very difficult as it causes the client to go into a > loop of sending bad auth, getting disconnected, trying to reconnect, sending > bad auth again, over and over. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.