Patrick Hunt commented on ZOOKEEPER-829:

Looks pretty good to me, some nits but in general ok. Ben/Mahadev?

1) use spaces not tabs
2) methods start with lower
3) use Long.toHexString to convert sessionid to hex (see other examples in the 
code, esp logging a sessionid)
4) you probably want to support both disconnect and close/expire to enable 
5) add some tests, both to verify this code, but also to provide a "blueprint" 
for other users
5.1) as part of 5 provide some reuseable code to testForceClose(sessionid) and 

> Add /zookeeper/sessions/* to allow inspection/manipulation of client sessions
> -----------------------------------------------------------------------------
>                 Key: ZOOKEEPER-829
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-829
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: server
>            Reporter: Todd Lipcon
>         Attachments: 829.diff
> For some use cases in HBase (HBASE-1316 in particular) we'd like the ability 
> to forcible expire someone else's ZK session. Patrick and I discussed on IRC 
> and came up with an idea of creating nodes in /zookeeper/sessions/<session 
> id> that can be read in order to get basic stats about a session, and written 
> in order to manipulate one. The manipulation we need in HBase is the ability 
> to write a command like "kill", but others might be useful as well.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to