[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913954#action_12913954
]
Thomas Koch commented on ZOOKEEPER-823:
---------------------------------------
I can not reproduce any test failure on my system. So the reported failures
from phunt and Junqueira are:
- phunt: NettyNettySuiteTest - ACLTest.testDisconnectedAddAuth(ACLTest.java:67):
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode =
ConnectionLoss for /
at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
at org.apache.zookeeper.ZooKeeper.setACL(ZooKeeper.java:1259)
I don't understand, what exactly this test should test. A code comment would
help. However I can imagine some race condition because the test does not wait
for a client connection to be established before continuing.
- phunt: NettyNettySuiteTest -
AsyncHammerTest.testObserversHammer(AsyncHammerTest.java:213)
I can't confirm this neither. However the test has some non determinism because
it waits only 60 seconds for a thread to join.
- Junqueira: NettyNettySuiteTest -
ClientTest.testMutipleWatcherObjs(ClientTest.java:241)
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode =
ConnectionLoss for /foo-89
I can't really help without access to machines where the tests fail. @Flavio
What are the specs of your test machine?
While investigating these failures I already felt the urge to continue my quest
for clean code and refactor: ZOOKEEPER-878, ZOOKEEPER-879 However these two
issues would blow up the patch even more.
> update ZooKeeper java client to optionally use Netty for connections
> --------------------------------------------------------------------
>
> Key: ZOOKEEPER-823
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-823
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.4.0
>
> Attachments: NettyNettySuiteTest.rtf,
> TEST-org.apache.zookeeper.test.NettyNettySuiteTest.txt.gz,
> ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch,
> ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch,
> ZOOKEEPER-823.patch
>
>
> This jira will port the client side connection code to use netty rather than
> direct nio.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
