Mahadev konar commented on ZOOKEEPER-820:

thsi does fix the if problem in the script (which took me sometime to realise 
was backwards :) ). Michi, can you also add the lsof check as follows:

if which lsof > /dev/null 2>&1; then "run the command to kill the process using 
lsof"; else "we dont do anything"; fi

Note that this is in addition to using pid checks. We can do the following -

on stop server:

- kill using pid file first
- kill using lsof, if any such process if present.

> update c unit tests to ensure "zombie" java server processes don't cause 
> failure
> --------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-820
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.3.1
>            Reporter: Patrick Hunt
>            Assignee: Michi Mutsuzaki
>            Priority: Critical
>             Fix For: 3.3.2, 3.4.0
>         Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, 
> ZOOKEEPER-820.patch
> When the c unit tests are run sometimes the server doesn't shutdown at the 
> end of the test, this causes subsequent tests (hudson esp) to fail.
> 1) we should try harder to make the server shut down at the end of the test, 
> I suspect this is related to test failing/cleanup
> 2) before the tests are run we should see if the old server is still running 
> and try to shut it down

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to