[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920686#action_12920686
]
Patrick Hunt commented on ZOOKEEPER-823:
----------------------------------------
I ran the latest patch 4 times on my hudson setup and saw 3 failures (1 each):
java.util.concurrent.TimeoutException: Did not connect
at
org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:124)
at
org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:51)
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode =
ConnectionLoss for /
at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
at org.apache.zookeeper.ZooKeeper.setACL(ZooKeeper.java:1259)
at
org.apache.zookeeper.test.ACLTest.testDisconnectedAddAuth(ACLTest.java:67)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:51)
[junit] 2010-10-13 09:16:42,245 [myid:] - INFO
[main:junit4zktestrunner$loggedinvokemet...@53] - TEST METHOD FAILED testAcls
[junit] org.apache.zookeeper.KeeperException$ConnectionLossException:
KeeperErrorCode = ConnectionLoss for /0
[junit] at
org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
[junit] at
org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
[junit] at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:640)
[junit] at org.apache.zookeeper.test.ACLTest.testAcls(ACLTest.java:104)
If this was failing in the Netty code I'd be inclined to push the code to trunk
and let things settle. However this is
in the mainline NIO code and I'm reticent to break existing functionality.
Perhaps a good idea would be to have Ben/Mahadev/Flavio review the patch and
see if they notice any issues.
I'd really like to get this in (esp as it's blocking other changes), so if we
could review this and resolve the issues asap that would be great.
> update ZooKeeper java client to optionally use Netty for connections
> --------------------------------------------------------------------
>
> Key: ZOOKEEPER-823
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-823
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.4.0
>
> Attachments: NettyNettySuiteTest.rtf,
> TEST-org.apache.zookeeper.test.NettyNettySuiteTest.txt.gz,
> testDisconnectedAddAuth_FAILURE, testWatchAutoResetWithPending_FAILURE,
> ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch,
> ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch,
> ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch,
> ZOOKEEPER-823.patch
>
>
> This jira will port the client side connection code to use netty rather than
> direct nio.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
