[
https://issues.apache.org/jira/browse/ZOOKEEPER-888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-888:
-------------------------------------
The patch looks good to me - thanks!
Could you add a test case that verifies the correct behaviour, if possible? (I
appreciate it can be hard to fake unrecoverable session errors). We keep
circling around the correct behaviour for this code block, and I'd like to
capture it in a test suite.
> c-client / zkpython: Double free corruption on node watcher
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-888
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-888
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, contrib-bindings
> Affects Versions: 3.3.1
> Reporter: Lukas
> Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: resume-segfault.py, ZOOKEEPER-888.patch
>
>
> the c-client / zkpython wrapper invokes already freed watcher callback
> steps to reproduce:
> 0. start a zookeper server on your machine
> 1. run the attached python script
> 2. suspend the zookeeper server process (e.g. using `pkill -STOP -f
> org.apache.zookeeper.server.quorum.QuorumPeerMain` )
> 3. wait until the connection and the node observer fired with a session
> event
> 4. resume the zookeeper server process (e.g. using `pkill -CONT -f
> org.apache.zookeeper.server.quorum.QuorumPeerMain` )
> -> the client tries to dispatch the node observer function again, but it was
> already freed -> double free corruption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
