Hadoop QA commented on ZOOKEEPER-905:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 1032885.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no new tests are needed for this 
                        Also please list what manual steps were performed to 
verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: 

This message is automatically generated.

> enhance zkServer.sh for easier zookeeper automation-izing
> ---------------------------------------------------------
>                 Key: ZOOKEEPER-905
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-905
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: scripts
>            Reporter: Nicholas Harteau
>            Assignee: Nicholas Harteau
>            Priority: Minor
>             Fix For: 3.4.0
>         Attachments: zkServer.sh.diff
> zkServer.sh is good at starting zookeeper and figuring out the right options 
> to pass along.
> unfortunately if you want to wrap zookeeper startup/shutdown in any 
> significant way, you have to reimplement a bunch of the logic there.
> the attached patch addresses a couple simple issues:
> 1. add a 'start-foreground' option to zkServer.sh - this allows things that 
> expect to manage a foregrounded process (daemontools, launchd, etc) to use 
> zkServer.sh instead of rolling their own to launch zookeeper
> 2. add a 'print-cmd' option to zkServer.sh - rather than launching zookeeper 
> from the script, just give me the command you'd normally use to exec 
> zookeeper.  I found this useful when writing automation to start/stop 
> zookeeper as part of smoke testing zookeeper-based applications
> 3. Deal more gracefully with supplying alternate configuration files to 
> zookeeper - currently the script assumes all config files reside in 
> $ZOOCFGDIR - also useful for smoke testing
> 4. communicate extra info ("JMX enabled") about zookeeper on STDERR rather 
> than STDOUT (necessary for #2)
> 5. fixes an issue on macos where readlink doesn't have the '-f' option.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to