[
https://issues.apache.org/jira/browse/ZOOKEEPER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930263#action_12930263
]
Hadoop QA commented on ZOOKEEPER-874:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12455142/ZOOKEEPER-874.patch
against trunk revision 1033155.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/11//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/11//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/11//console
This message is automatically generated.
> FileTxnSnapLog.restore does not call listener
> ---------------------------------------------
>
> Key: ZOOKEEPER-874
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-874
> Project: Zookeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.1
> Reporter: Diogo
> Assignee: Diogo
> Priority: Trivial
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-874.patch
>
>
> FileTxnSnapLog.restore() does not call listener passed as parameter. The
> result is that the commitLogs list is empty. When a follower connects to the
> leader, the leader is forced to send a snapshot to the follower instead of a
> couple of requests and commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
