[
https://issues.apache.org/jira/browse/ZOOKEEPER-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930266#action_12930266
]
Hadoop QA commented on ZOOKEEPER-906:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12457770/ZOOKEEPER-906.patch
against trunk revision 1033155.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/9//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/9//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/9//console
This message is automatically generated.
> Improve C client connection reliability by making it sleep between reconnect
> attempts as in Java Client
> -------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-906
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-906
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Radu Marin
> Assignee: Radu Marin
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-906.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Currently, when a C client get disconnected, it retries a couple of hosts
> (not all) with no delay between attempts and then if it doesn't succeed it
> sleeps for 1/3 session expiration timeout period before trying again.
> In the worst case the disconnect event can occur after 2/3 of session
> expiration timeout has past, and sleeping for even more 1/3 session timeout
> will cause a session loss in most of the times.
> A better approach is to check all hosts but with random delay between
> reconnect attempts. Also the delay must be independent of session timeout so
> if we increase the session timeout we also increase the number of available
> attempts.
> This improvement covers the case when the C client experiences network
> problems for a short period of time and is not able to reach any zookeeper
> hosts.
> Java client already uses this logic and works very good.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
