[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930548#action_12930548 ]
Patrick Hunt commented on ZOOKEEPER-909: ---------------------------------------- Hi Thomas. Still shaky legs on getting the patch queue up and working again. Shouldn't keep us from getting this committed though. re javadoc, this is not an issue for the other patches afaict, any idea why it's just showing up for this patch? There are two sets of tests, java and the c client binding. Unfortunately hudson currently does not highlight c failures on the summary page, you need to checkout the console (usually raw) in the case where the tests fail (but not java test). Looking at console I see: [exec] [exec] ZooKeeper server process failed ZooKeeper server NOT startedRunning I've notified Nigel about this to see is he has insight (saw it on a couple other jiras). So far he hasn't had a chance to look into it. > Extract NIO specific code from ClientCnxn > ----------------------------------------- > > Key: ZOOKEEPER-909 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-909 > Project: Zookeeper > Issue Type: Sub-task > Components: java client > Reporter: Thomas Koch > Assignee: Thomas Koch > Fix For: 3.4.0 > > Attachments: ClientCnxnSocketNetty.java, ZOOKEEPER-909.patch, > ZOOKEEPER-909.patch, ZOOKEEPER-909.patch, ZOOKEEPER-909.patch, > ZOOKEEPER-909.patch > > > This patch is mostly the same patch as my last one for ZOOKEEPER-823 minus > everything Netty related. This means this patch only extract all NIO specific > code in the class ClientCnxnSocketNIO which extends ClientCnxnSocket. > I've redone this patch from current trunk step by step now and couldn't find > any logical error. I've already done a couple of successful test runs and > will continue to do so this night. > It would be nice, if we could apply this patch as soon as possible to trunk. > This allows us to continue to work on the netty integration without blocking > the ClientCnxn class. Adding Netty after this patch should be only a matter > of adding the ClientCnxnSocketNetty class with the appropriate test cases. > You could help me by reviewing the patch and by running it on whatever test > server you have available. Please send me any complete failure log you should > encounter to thomas at koch point ro. Thx! > Update: Until now, I've collected 8 successful builds in a row! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.