Hadoop QA commented on ZOOKEEPER-756:
-1 overall. Here are the results of testing the latest attachment
against trunk revision 1035727.
-1 @author. The patch appears to contain 4 @author tags which the
Zookeeper community has agreed to not allow in code contributions.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
This message is automatically generated.
> some cleanup and improvements for zooinspector
> Key: ZOOKEEPER-756
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-756
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib
> Affects Versions: 3.3.0
> Reporter: Thomas Koch
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
> Attachments: zooInspectorChanges.patch, ZOOKEEPER-756.patch
> Copied from the already closed ZOOKEEPER-678:
> * specify the exact URL, where the icons are from. It's best to include the
> link also in the NOTICE.txt file.
> It seems, that zooinspector finds it's icons only if the icons folder is in
> the current path. But when I install zooinspector as part of the Zookeeper
> Debian package, I want to be able to call it regardless of the current path.
> Could you use getRessources or something so that I can point to the icons
> location from the wrapper shell script?
> Can I place the zooinspector config files in /etc/zookeeper/zooinspector/ ?
> Could I give zooinspector a property to point to the config file location?
> There are several places, where viewers is missspelled as "Veiwers". Please
> do a case insensitive search for "veiw" to correct these. Even the config
> file "defaultNodeVeiwers.cfg" is missspelled like this. This has the
> potential to confuse the hell out of people when debugging something!
This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.