[ https://issues.apache.org/jira/browse/ZOOKEEPER-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934066#action_12934066 ]
Hadoop QA commented on ZOOKEEPER-937: ------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12460076/zk_solaris_zkEnv.patch against trunk revision 1036967. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/41//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/41//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/41//console This message is automatically generated. > test -e not available on solaris /bin/sh > ---------------------------------------- > > Key: ZOOKEEPER-937 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-937 > Project: Zookeeper > Issue Type: Bug > Components: scripts > Affects Versions: 3.3.0, 3.3.1, 3.3.2 > Environment: SunOS xxx 5.10 Generic_142901-13 i86pc i386 i86pc Solaris > Reporter: Erik Hetzner > Assignee: Erik Hetzner > Fix For: 3.4.0 > > Attachments: zk_solaris_zkEnv.patch, zk_solaris_zkEnv.patch > > > test -e FILENAME is not support on /bin/sh in solaris. This is used in > bin/zkEnv.sh. We can substitute test -f FILENAME. Attaching a patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.