Am 28.06.2009, 09:46 Uhr, schrieb Vincent Fretin  
<vincent.fre...@gmail.com>:

> Hi,
> I patched Products.CMFCore trunk 2.2 as well. I hope I didn't break  
> anything.

Difficult to know as there doesn't seem to be any test for this. I think  
it would be a good idea to have one

Apart from the use of list comprehension, the change seems to be:

portal_types.listTypeInfo(self)

versus

portal_types.listTypeInfo()

Where ther is type information which leads to isConstructionAllowed()  
being called twice. The change shouldn't have any unpleasant side effects  
and is certainly easier to understand.

I would add that the changed code exceeds the recommended maxium line  
length.

Charlie
-- 
Charlie Clark
Helmholtzstr. 20
Düsseldorf
D- 40215
Tel: +49-211-938-5360
GSM: +49-178-782-6226
_______________________________________________
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Reply via email to