On Mon, Aug 18, 2008 at 3:19 PM, Chris Withers <[EMAIL PROTECTED]> wrote:
> Hi Benji,
> Was a bit shocked to see your name against the rather disappointing
> commenting out of a doctest in doctest.py (lines 2214-2218).

Commenting out that test was an accident of a merge.

But, that doesn't really matter much, because test in question has never
run, and can never have passed (since the time when zope.testing's
doctest was forked from Python).  It expects to call functions in the
current module (which is zope.testing.doctest) to mutate module globals
and see the results in the globals of the module imported by "import
doctest" (which will be the doctest from the standard library).

I suggest deleting the test in question.  It doesn't really test
anything worth testing as far as I can tell.  Then we should make
bin/test run the tests in doctest.py.

Ultimately we'd really like to defork doctest, but that's a non-trivial
Benji York
Senior Software Engineer
Zope Corporation
Zope-Dev maillist  -  Zope-Dev@zope.org
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope )

Reply via email to