-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jim Fulton wrote:
> On Feb 24, 2009, at 9:26 AM, Tres Seaver wrote:
> ...
>>> As for TestRequest, I could update the setup.py of various packages  
>>> that
>>> currently depend on zope.publisher just for TestRequest.  I would  
>>> make
>>> zope.publisher a test-only requirement.
>> Frankly, any code using a testing stub which is that heavyweight needs
>> to be refactored.
> 
> 
> There's nothing all that heavyweight about TestRequest.

- - It derives from BrowserRequest, which means carrying along a *lot*
  of extra implementation baggage.  Tests which use this class, rather
  than stubbing out a dummy request which provides only the API required
  by the application-under-test, will tend to grow unexpected /
  undesirable tentacles to the request implementation.

- - Using TestRequest involves pulling in all of zope.publisher, a *big*
  dependency;  Shane wants to reduce such dependencies.



Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tsea...@palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJpBxw+gerLs4ltQ4RAosKAKDNmJoShgxtFrhi3rVFYqa3H+ncVACgmGU8
TOcde0xx65K1KeIopuy3hpk=
=/+UR
-----END PGP SIGNATURE-----
_______________________________________________
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )

Reply via email to