On Mon, Aug 17, 2009 at 1:43 PM, Gary Poster<gary.pos...@gmail.com> wrote:
> Two teams here at Canonical just encountered the STAGGER_RETRIES
> behavior in
> . I don't see anything in tests or comments to explain it. Our
> guess is that it tries to put some breathing room around retries so
> that the chance of a conflict error might be reduced.
Yup, although I think it's misguided in this case. With conflicts,
there's always a winner, so it makes sense to try again right away.
> In one of our tests setting STAGGER_RETRIES to False reduced a test
> run from almost 9 minutes to about 1 minute (see
> . We have papered this over in our test suite to no ill effect,
> giving speed advantages. We wonder if we should remove the behavior
> entirely, even in production.
I think so.
> 1) Why should the time.sleep go into supportsRetry rather than retry?
> it seems really odd to have it in the method that returns a boolean,
> rather than the one that does the work.
> 2) Can someone give some background for this code? Can they give
> examples of it actually helping anything?
I doubt it.
> We'd like to improve this, minimally by adding some explanatory
> comments, and maybe by changing, moving, or removing this code.
Let's just remove it.
Zope-Dev maillist - Zope-Dev@zope.org
** No cross posts or HTML encoding! **
(Related lists -