It looks good. But, the try/except and instanciation of the MessageFactory could be done only once, in the __init__ of the package for instance. That would be a central place to change it and to import from.
2010/2/23 Stephan Richter <srich...@cosmos.phy.tufts.edu>: > On Tuesday 23 February 2010, Tres Seaver wrote: >> In order to make zope.schema more useful outside of Zope, I would like >> to make the dependency on zope.i18nmessageid optional. I have checked >> in a branch which does this: >> >> http://svn.zope.org/zope.schema/branches/tseaver-optional_i18nmessageid >> >> Objections? >> > > The changes look good. > > Regards, > Stephan > -- > Entrepreneur and Software Geek > Google me. "Zope Stephan Richter" > _______________________________________________ > Zope-Dev maillist - zope-...@zope.org > https://mail.zope.org/mailman/listinfo/zope-dev > ** No cross posts or HTML encoding! ** > (Related lists - > https://mail.zope.org/mailman/listinfo/zope-announce > https://mail.zope.org/mailman/listinfo/zope ) > _______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )