-----BEGIN PGP SIGNED MESSAGE-----
Chris McDonough wrote:
> Within the last few months you committed the following change to
> The commit message is "Fixed the compilation of the C extension with
> python 2.6: refactored it as a setuptools Feature." Can I ask what
> problem was being fixed with this commit?
> It undid work I did in this revision:
> I should have left a comment in there: the work was effectively there to
> support building zope.i18nmessageid on Jython and other platforms like
> GAE that do not support C extensions at all, even optionally. The
> package no longer builds on Jython ("error: Setup script exited with
> error: Compiling extensions is not supported on Jython"), although to be
> honest I don't really understand why not. I'm hoping we can find a way
> to retain whatever fix you were trying to make but still allow the
> package to build on Jython, but I think I need to understand what
> problem you were fixing first.
I think there is a good case for making the C extension an "optional"
setuptools feature: nobody acutally *needs* that extension built to
have their application work.
Jim has asserted (but not really explained) that the C extension closes
some kind of security hole. I don't see any credible attack vector
myself, but then I no longer believe it worthwhile to devote my own
energy to defending against malicious TTW programmers.
The change here is to remove 'standard=True' from the feature
constructor. Developers who want the feature enabled can then build the
$ python setup.py --with-codeoptimization bdist_egg
We could then update the zc.recipe.egg:custom recipe to allow specifying
features to be installed for a given egg.
Tres Seaver +1 540-429-0999 tsea...@palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
Zope-Dev maillist - Zope-Dev@zope.org
** No cross posts or HTML encoding! **
(Related lists -