On Thu, Dec 09, 2010 at 12:58:18PM +0100, Zope Tests Summarizer wrote: > Summary of messages to the zope-tests list. > Period Wed Dec 8 12:00:00 2010 UTC to Thu Dec 9 12:00:00 2010 UTC. > There were 83 messages: 8 from Zope Tests, 4 from buildbot at pov.lt, 19 from > buildbot at winbot.zope.org, 11 from ccomb at free.fr, 41 from jdriessen at > thehealthagency.com.
When can we have the new pretty summarizer? > Test failures > ------------- > > Subject: FAILED : ZTK 1.0 / Python2.6.5 Linux 64bit > From: ccomb at free.fr > Date: Wed Dec 8 19:46:28 EST 2010 > URL: http://mail.zope.org/pipermail/zope-tests/2010-December/026043.html Failure in test testHELP (zope.server.ftp.tests.test_ftpserver.Tests) in zope.server-3.6.2. AFAICS the test is basically: * start a server in one thread that does socket.send("message #1\r\n") # some python code runs here socket.send("message #2\r\nmessage #3\r\n") * have it do this in a different thread reply = socket.recv(10000) * assert that reply == "message #1\r\nmessage #2\r\nmessage #3\r\n" This sometimes works, and sometimes doesn't---unsurprisingly. This might be a sufficient workaround: Index: src/zope/server/ftp/server.py =================================================================== --- src/zope/server/ftp/server.py (revision 118761) +++ src/zope/server/ftp/server.py (working copy) @@ -194,7 +194,7 @@ class FTPServerChannel(LineServerChannel def cmd_help(self, args): 'See IFTPCommandHandler' - self.reply('HELP_START') + self.reply('HELP_START', flush=False) self.write('Help goes here somewhen.\r\n') self.reply('HELP_END') as there's buffering going on on the Python level -- up to 9000 chars by default -- so it would result in the server doing a single socket.send(). It's still not entirely Correct; the right thing would be to fix the receiving side to aggregate the packets until the full message is received (or a timeout occurs). Any takers? I can't even test the workaround, since this test passes on my machine. Marius Gedminas -- http://pov.lt/ -- Zope 3/BlueBream consulting and development
Description: Digital signature
_______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )