Hi Jim,

   If you are happy to wait a few days more, before including these into 
buildbot, I will create a branch to get these tests back into the same zope 
testing framework. From what Andrew Bennetts said in his response, this is 
very possible but will probable require a update of Twisted to the trunk. But 
then we can do what we are doing now and just have svn:external pointing to a 
specific revision of the Twisted trunk.

  Michael

On Sunday 29 January 2006 14:48, Jim Fulton wrote:
> Michael Kerrin wrote:
> > Hi All,
> >
> >   I have just fixed issue #533 and it just reminded me that I have some
> > test for the twisted ftp server written using the Twisted trial testing
> > framework.
> >
> >   The reason for this is that at the Neckar sprint I tried to write tests
> > for the zope.app.twisted.ftp.ftp.ZopeFTPShell. This object can be thought
> > of has middle ware between Twisted and Zope, in fact it lives more up in
> > the Twisted server then in Zope. Has most of the methods in this class
> > return Twisted deferred objects it was next to impossible to test these
> > methods using the standard zope testing framework.
>
> Why is that?
>
>  > All these tests are pretty much
> >
> > self contained i.e. even by removing zope.app.ftp the tests still pass
> > and there are only 26 of them.
> >
> >   I am thinking that it would be a good idea to include these tests as
> > part of the buildbot process, just after all the standard zope tests have
> > run. It means that if some one apart from myself has to make any changes
> > to the zope.app.twisted.ftp module, they will learn pretty quickly if
> > something has broken, or if the Twisted external is updated.
> >
> >   I have no idea on how / who to ask for this. But to run the tests we
> > just have to run in the same place has the standard zope tests:
> >
> >     ./trial.py zope.app.twisted.ftp.test
> >
> >   There is a --reporter argument to this trial program that can take one
> > of the following values bwverbose, text, verbose, or summary to control
> > the amount of output.
> >
> >   I hope this isn't to difficult to add in.
>
> I'll look at adding this.
>
> Jim

-- 
Michael Kerrin

55 Fitzwilliam Sq.,
Dublin 2.

Tel: 087 688 3894
_______________________________________________
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com

Reply via email to