* Philipp von Weitershausen <[EMAIL PROTECTED]> [2006-09-22 10:49]:
> Wolfgang Schnerring wrote:
> >>>However, when I tried to refactor zope.location.location.LocationProxy
> >>>to use said base classes, it broke the functional tests for
> >>>zope.app.apidoc.introspector -- for reasons I totally don't
> >>>understand.
> I briefly looked at the test failure. THis issue requires more digging. 
> Fact is, if tests are failing, you should revert your revision. You can 
> still check it in, but on a branch. Refactorings like this one don't 
> warrant breaking the trunk.

Of course. I've immediately changed the LocationProxy to not use the
base class, but assign the internal attributes manually (as it was
before). But since all tests pass now, I'm confident not to revert the
refactored zope.decorator.
I'm afraid I don't have time nor expertise to dig into the apidoc
myself at the moment, though.

Zope3-dev mailing list
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com

Reply via email to