I can't seem to make comments on the issue in the tracker ATM, but I take issue with the attached. I think default tests created by default templates should assume default plone, and there's nothing wrong with that.

I don't think it's too much to ask someone to change a test to fit their needs after the code is generated.

IMHO, tests should fail if assumptions aren't meant, and that's totally OK. I think its a mistake to want the generated tests to pass by default and it's especially bad do anything that is dissimilar to what a normal user does to make them pass.

JJ

Begin forwarded message:

From: "plone.org Administrator" <disc...@antiloop.plone.org>
Date: March 24, 2010 5:24:34 AM EDT
To: zopeskel@lists.plone.org
Subject: [Zopeskel] [ZopeSkel Issue Tracker] #40 - New issue: [patch, trivial] archetypes browser tests depend on login_portlet
Reply-To: Zopeskel Users and Developers <zopeskel@lists.plone.org>

A new issue has been submitted to the Issue tracker tracker by Guido Stevens and awaits confirmation.

Issue Information

Issue
[patch, trivial] archetypes browser tests depend on login_portlet (http://plone.org/products/zopeskel/issues/40 )
Issue Details:

The boilerplate browser tests generated by

# paster create -t archetype

and by

# paster addcontent contenttype

use the login portlet on the home page to log in to the site.



This is not a problem when performing stand-alone tests of the
content type package.



However, browser tests are integration tests, and when combining
the content type package with, say, a theme package that hides the
login portlet on the home page,

then running a combined test

# bin/instance test -s my.contenttype -s my.theme

    ...

    LookupError: name '__ac_name'



The fix is simple: use the dedicated /login_form to log into the
site. See attached diffs.



I don't have a ZopeSkel development sandbox, don't know how to
test such a "meta" package -- but have implemented and verified
this fix in my own content type package.
This is an automated email, please do not reply - plone.org Administrator
_______________________________________________
ZopeSkel mailing list
ZopeSkel@lists.plone.org
http://lists.plone.org/mailman/listinfo/zopeskel

_______________________________________________
ZopeSkel mailing list
ZopeSkel@lists.plone.org
http://lists.plone.org/mailman/listinfo/zopeskel

Reply via email to