Review: Needs Information Hi Markos, I believe there is a problem with the fix to TextNode constructor.
The problem is in the 3452-3468 lines, which checks that the parent node has only comment and pi nodes as children. Suppose that we are building the following tree <a>hi<!-- i -->can<!--crash --></a>, when zorba constructs "can" the assertion at line 3465 is violated. I think that a fix would be to extend the if at line 3462 is with && child->getNodeKind() !=store::StoreConsts::textNode (or, shorter, "turn around" the if). Cheers, Federico -- https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/76750 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
