Review: Needs Information

Hi Markos,
I believe there is a problem with the fix to TextNode constructor.

The problem is in the 3452-3468 lines, which checks that the parent node has 
only comment and pi nodes as children.
Suppose that we are building the following tree <a>hi<!-- i -->can<!--crash 
when zorba constructs "can" the assertion at line 3465 is violated.

I think that a fix would be to extend the if at line 3462 is with && 
child->getNodeKind() !=store::StoreConsts::textNode (or, shorter, "turn around" 
the if).

Your team Zorba Coders is subscribed to branch lp:zorba.

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to