Chris Hillery has proposed merging lp:~zorba-coders/zorba/http-client-version 
into lp:zorba/http-client-module.

Requested reviews:
  Chris Hillery (ceejatec)
  Matthias Brantner (matthias-brantner)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/http-client-version/+merge/88986

The http-client.xq file uses Zorba versioning to declare itself to be version 
1.0. However, the DECLARE_ZORBA_MODULE() entry in CMakeLists.txt did not 
declare the version at all. This turns out to cause trouble with another fix I 
am making.

However, I am curious: Is this the correct fix? Or should the http-client.xq 
module be unversioned, since it is from expath? I thought that generally 
modules from other sources (such as functx) we left as unversioned. However, 
the expath file module is also versioned, so I am unsure.
-- 
https://code.launchpad.net/~zorba-coders/zorba/http-client-version/+merge/88986
Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module.
=== modified file 'src/org/expath/ns/CMakeLists.txt'
--- src/org/expath/ns/CMakeLists.txt	2011-08-10 09:40:41 +0000
+++ src/org/expath/ns/CMakeLists.txt	2012-01-18 07:53:36 +0000
@@ -12,4 +12,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-DECLARE_ZORBA_MODULE (URI "http://expath.org/ns/http-client"; FILE "http-client.xq")
+DECLARE_ZORBA_MODULE (URI "http://expath.org/ns/http-client"; FILE "http-client.xq" VERSION 1.0)

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to