Review: Needs Information It looks very good.
Should the actual atomic type be present in the attribute element? If you have "by @id" where @id can be 1 or "1", you might want to create two index keys? If a key returns (), you might want to distinguish with empty string for probing later? By using keys(), I got the following output: <key xmlns="http://www.zorba-xquery.com/modules/store/static/indexes/dml"><attribute value="hello"></attribute><attribute value="4"></attribute></key> Is the namespace useful or does it just make the life of the user harder? Why isn't it: <keys><key value="hello" /><key value="4" /></keys> Again, could you explain me how I'm supposed to probe from such XDM if one of the actual key returned empty sequence? Should the keys have a position attribute or something? The doc/zorba/xqddf.dox doesn't seem to mention the function, it should no? The xqdoc seems to have a formatting problem: the output example for keys() goes out of its box. -- https://code.launchpad.net/~zorba-coders/zorba/bug900677/+merge/88973 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : firstname.lastname@example.org Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp