Review: Needs Fixing

I think the changes are not O.K. , please see below for a brief description of 
the tests I did.
I have not approved the changes yet because I would need another opinion on the 
2 issues I have raised below and about the fix proposed for the bug I found.

I have checked the following options:
Check 1)
cmake -Dallmodules=ON -Doutdir="MY_LOCATION" -P DownloadModules.cmake
I then compiled and run all tests successfully for all external modules (I ran 
"ctest -R _module").

Check 2)
cmake -Dmodname=email -Dnotags=ON -Doutdir="MY_LOCATION" -P 
DownloadModules.cmake
CMake Error at DownloadModules.cmake:128 (message):
  Failed to download 'data-cleaning' after 3 attempts, giving up.

Check 3)
cmake -Dmodname=email -Doutdir="MY_LOCATION" -P DownloadModules.cmake
CMake Error at DownloadModules.cmake:128 (message):
  Failed to download 'data-cleaning' after 3 attempts, giving up.

For this issue I will try to propose a fix.


Issue 1)
Paul reported that he had an issue with the email module that I could not 
reproduce.
Anyway, Juan (who managed to reproduce the error) said that he found an work 
around by changing the ExternalModule.config to have email module as the last 
module to branch out.

IMO, I would propose to include Juan's proposed fix in this merge as well.


Issue 2) 
What is the status of the following external modules:
- lp:zorba/exi-module 
- lp:zorba/queue-module 
- lp:zorba/stack-module 
Should they be included in the ExternalModule.config already?

AFAIK at least the last 2 external modules(queue, stack) are finished.



-- 
https://code.launchpad.net/~zorba-coders/zorba/download-modules/+merge/93335
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to