Review: Needs Fixing

The change provides a great extension to all of Zorba's language bindings.

Two things:
- it currently doesn't build on my machine (Ubuntu 11.04 with gcc 4.5.2)


[ 97%] Building CXX object 
swig/python/CMakeFiles/_zorba_api_python.dir/zorba_apiPYTHON_wrap.cxx.o
In file included from /usr/include/python2.7/Python.h:8:0,
                 from 
/home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:158:
/usr/include/python2.7/pyconfig.h:1155:0: warning: "_POSIX_C_SOURCE" redefined
/usr/include/features.h:163:0: note: this is the location of the previous 
definition
/usr/include/python2.7/pyconfig.h:1177:0: warning: "_XOPEN_SOURCE" redefined
/usr/include/features.h:165:0: note: this is the location of the previous 
definition
/home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx: In function 
‘PyTypeObject* _PySwigObject_type()’:
/home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:1855:7: 
warning: missing initializer for member ‘_typeobject::tp_version_tag’
/home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx: In function 
‘PyTypeObject* _PySwigPacked_type()’:
/home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:2030:7: 
warning: missing initializer for member ‘_typeobject::tp_version_tag’
/home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx: In member 
function ‘int SAX2Attributes::getIndex(const char*, const char*) const’:
/home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:2894:14: 
warning: converting to non-pointer type ‘int’ from NULL
/home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx: In member 
function ‘int SAX2Attributes::getIndex(const char*) const’:
/home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:2902:14: 
warning: converting to non-pointer type ‘int’ from NULL
In file included from 
/home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:3471:0:
/home/mbrantner/zorba/build/swig/python/StaticContext.h: At global scope:
/home/mbrantner/zorba/build/swig/python/StaticContext.h:116:3: error: 
‘TypeIdentifier’ does not name a type
/home/mbrantner/zorba/build/swig/python/StaticContext.h:117:3: error: 
‘TypeIdentifier’ does not name a type
/home/mbrantner/zorba/build/swig/python/StaticContext.h:118:3: error: 
‘TypeIdentifier’ does not name a type
/home/mbrantner/zorba/build/swig/python/StaticContext.h:120:39: error: 
‘TypeIdentifier’ does not name a type
/home/mbrantner/zorba/build/swig/python/StaticContext.h:120:55: error: ISO C++ 
forbids declaration of ‘aType’ with no type


- Also, I'm a little bit worried about the absence of tests for the language 
bindings other than Java. We should at least have some testing for them (e.g. 
PHP, Python, and Ruby).
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug931580/+merge/92818
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/bug931580 into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to