A small code improvement: rather thah doing a dynamic_cast to check if an expr 
is an fo_expr, use the get_expr_kind() method. So, the code would look like 
this:

if (right->get_expr_kind() == fo_expr_kind)
{
  fo_expr* lfoExpr = static_cast<fo_expr*>(right.getp());
  etc....;
}

Also, please respect the coding style of the files you update. In this case, 
put the "{" in a separate line.

-- 
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to