Review: Needs Fixing

Sorry, this fix isn't right.

1. You can't depend on the relative path to the Zorba source directory, because 
Zorba could be built with ZORBA_MODULES_DIR pointing anywhere.

2. You also can't depend on the build directory being a direct subdirectory of 
the source directory.

3. Finally, you can't depend on Zorba even being part of this build, because it 
is possible to build a non-core module against a Zorba binary installation. So, 
there may not be any Zorba source directory, and the "xqdoc" target may not 
exist.

I think trying to move this command out of the trunk isn't a good idea.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255_image_module/+merge/105991
Your team Zorba Coders is subscribed to branch lp:zorba/image-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to