Review: Needs Fixing

Mostly looks excellent. I still think the SITEARCH issue is a problem, but I 
see that it also exists in the Java SWIG code as Rodolfo says, so I will file a 
separate bug report about that.

The only change I would request: Rodolfo, in swig/xqj/CMakeLists.txt, you have 
separate code using the new CMake "UseJava" functionality if the CMake version 
is greater than 2.8.6. I like that, because the ADD_CUSTOM_COMMAND(POST_BUILD) 
technique used otherwise is a kludge that doesn't get the dependencies right. 
Could you also use that same UseJava technique in swig/java/CMakeLists.txt ?
Your team Zorba Coders is subscribed to branch lp:zorba.

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to