In order: 0) It certainly makes sense to consolidate on a single FindJNI.cmake, if in fact we need our own at all. The right place for it is in util-jvm. It will be necessary to ensure that other modules use that version as well, probably by extending the util-jvm "use file" to extend CMAKE_MODULE_PATH.
1) This change also makes sense if we need a custom FindJNI.cmake. 2) I don't like these changes, although I'm not sure of the alternative. IMHO the existing FindJNI code with all of its many specific hard-coded paths is bogus, and your change just extends the bogusness. There Must Be A Better Way(tm). (Also - what was the reason you changed JAVA_AWT_INCLUDE_DIRECTORIES to JAVA_AWT_INCLUDE_PATH? That doesn't seem to make sense.) FYI, it seems to work for me on Ubuntu 11.10, and I am using Sun JDK rather than OpenJDK which might also be better supported. At any rate, no, I do not believe that this should be in Zorba 2.5 because it's too late, and because I'm unwilling to toss in a hack at the last minute that I'm not sure I agree with. Also, it appears that the work-around for anyone who runs into trouble is easy: Set JAVA_HOME in your environment before running CMake. ** Changed in: zorba Status: Incomplete => Confirmed ** Changed in: zorba Importance: High => Medium -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/989490 Title: on ubuntu 12.04, Java and/or JNI not found Status in Zorba - The XQuery Processor: Confirmed Bug description: Hey Chris Java and/or JNI is not found on ubuntu 12.04. Therefore, fop doesn't work. I think the paths to java stuff changed on ubuntu 12.04. Maybe, cmake 2.8.8 is handle those changes. cmake 2.8.7 is not. David To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/989490/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : email@example.com Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp