Review: Needs Information

1. Don't you have one too many ../ when computing _JAVA_HOME from _JAVA_BIN_LOC 
? On my Ubuntu 11.10, at least, java is in 
/usr/lib/jvm/java-6-sun/jre/bin/java, and JAVA_HOME should be 
/usr/lib/jvm/java-6-sun I believe.

2. Also, FYI, a variable in CMake is considered FALSE if its value ends with 
-NOTFOUND. So you could simplify your IF() to just


3. Minor typo: "FIndJNI.cmake".
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to