Review: Needs Information I've reviewed the serialization changes. One tiny issue: I think in jsoniq_emitter::emit_end(), you should call emit_end() on either theXMLEmitter or theJSONEmitter depending on theEmitterState. I know that right now, neither the XML nor the JSON emitters actually do anything in emit_end(), but if they ever need to do something in the future, this will be a bug. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/92171 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/jsoniq into lp:zorba.
-- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
