1. Why are the asserts in XmlTree::getType() converted to ifs? Did th asserts 
actually trigger ever? 

2. The setTree() methods has been made virtual. This si not good, because the 
method is used rather often. 

3. The 6 lines:

#ifndef EMBEDED_TYPE
#ifndef NDEBUG
ATTRIBUTE_ELEMENT_INVARIANT1;
ATTRIBUTE_ELEMENT_INVARIANT2;
ATTRIBUTE_ELEMENT_INVARIANT3;
#endif
#endif

should be converted to a single line via the use of a macro.

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to