> Hi Markos,
> 
> Thanks a lot!
> 
> 2. and 3. should be fixed.
> 
About 2, the problem is still there, because setTree now calls getNodeKind(), 
which is also a virtual method. But this is a more general problem; basically, 
we need a non-virtual getNodeKindInternal() method to be used everywhere inside 
the simple store (would this work for the Sausalito store as well?). So, you 
don't have to do anything about it in this branch. 


> About 1: invariant 3 checks that the tree does not contain a type under
> certain circumstances, so it requires getType() to fail in a gracious manner.
> The asserts that were in getType() are actually "relocated" to the element and
> attribute invariants that are more precise.
> 
> Does it make sense?

Ok.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to