Review: Needs Fixing

Interesting! However, XMLString::transcode() returns a memory buffer that the 
caller must free by calling XMLString::release(), so I believe this change 
introduces a memory leak (unless InputSource will free them, which I don't 
think it does). I'm actually not 100% sure how to solve this - I guess 
IstreamInputSource could free them in its destructor, if it can tell that it 
needs to do so?
Your team Zorba Coders is subscribed to branch lp:zorba.

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to