> Problems: > - Based on the paging.xqlib module (in the tests), the following query should > return the empty sequence: > > idml:probe-index-range-value-skip(xs:QName("data:idx-age-range-val"), > 10, 2, 3, true(), true(), true(), true()) Fixed > > But it returns all the items with age 3. This seems wrong. > > - idml:probe-index-range-value sorts the nodes implicitly in document order, > i.e. they are not returned in the order of the index keys. The skipping is > done before the sorting. This might be really confusing to the user. > Essentially, he doesn't have a way to know which items are skipped. We have > talked to Markos and he agreed that we remove the sorting from the range-value > functions and only add it if the probe is used to answer queries. Fixed by you > > - The module in modules/com/zorba- > xquery/www/modules/store/static/indexes/dml.xq doesn't contain the -skip > functions. It looks like the probe-index-point-value appears twice and is > missing the -skip suffix. The same seems to be the case for the probe-index- > range-value function. Also, the documentation for what is probably supposed to > be the -skip function is very long. Maybe it can make a reference to the > original probe function and only mention the fact that it returns the values > for the keys. done > > Minor issues: > - I wasn't able to merge the trunk into this branch because there are tons of > merge conflicts in translator.cpp. Also, bzr reports that a criss-cross merge > was encountered. Probably because the collection-skipping branch was merged in > the meantime. I don't understand why the merge proposal doesn't show any > conflict. Without merging the trunk, I can't link because of the uuid_generate > problem. done > > - There seem to be plenty of whitespace-only changes in > src/functions/signature.cpp? I couldn't figure out whether there are actually > semantic changes in that file. Are they necessary (e.g. removing tabs)? In signature.cpp are not whitespace changes only. There is an additional constructor too. But I do not understand how I can avoid the whitespace changes. If I do a simple change in the file with vi, I get them. -- https://code.launchpad.net/~davidagraf/zorba/paging_index_probe/+merge/122621 Your team Zorba Coders is subscribed to branch lp:zorba.
-- Mailing list: https://launchpad.net/~zorba-coders Post to : firstname.lastname@example.org Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp