I am going to approve, but it would be nice if you added an "iter" test to make 
sure that the optimization is applied and we won't loose it somehow in the 
future. To do so, you must first make PrinterVisitor print theNeedToCpy data 
member of the various ZorbaInsertNodesXXX iterators. This will probably involve 
messing with the runtime code generator (ouch!). Then you print the iterators 
plan of your no_copy_01.xq, and save it in 
test/rbkt/ExpCompilerResults/IterPlans/zorba/collections/no_copy_01.iter.

-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to