Review: Needs Fixing

1. Why return made-up numbers, e.g., -1000, etc?  Why not simply return the 
actual exit status?  Of course this implies that you'd have to implement XQuery 
functions that do the equivalent of the W* macros.  Either that, or return XML 
data, e.g.:

  <process id="1234" raw-exit-code="0" status="normal"/>


  <process id="1234" raw-exit-code="56" status="signal" signal="5" 

2. When you throw the USER_EXCEPTION, why not include the actual OS-level error 
message?  There is code in src/util/error_util.h.  Yes, this implies that this 
code would have to be moved to the public API.
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to